fix(popup): handle auto scroll and remove useless deps effect #5785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

philibea wants to merge 181 commits into beta from popup-event

+53,639 −412,225

Collaborator

philibea commented Nov 17, 2025

Summary

Type

Enhancement

Summarise concisely:

What is expected?

fix deps of useEffect/useLayoutEffect
fix scroll issue of selection option into a modal offset content

The following changes where made:

Relevant logs and/or screenshots

Page	Before	After
url	screenshot	screenshot
url	screenshot	screenshot

matthprost and others added 30 commits

October 22, 2025 17:14


          chore: beta opening (#5429)

f48d80d


          chore: fix changeset (#5430)

5b73f47


          feat(Button): emotion removal vanilla extract (#5428)

669bb9f

* feat(Button): emotion removal vanilla extract

* fix: unit tests and checks

* fix: update prefix to add uv

* fix: snapshot update


          chore: release (beta) (#5427)

588aedb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          chore: changeset for release of themes (#5433)

e788dd0


          chore: release (beta) (#5434)

57763d3

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          fix: theme provider to inject theme in head (#5435)

1be87b4


          chore: release (beta) (#5436)

a68ba2a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          fix(Snippet): remove after element on most of the lines (#5437)

3eacd49

* fix(Snippet): remove after element on most of the lines

* fix: feedback


          fix(TextArea): take all space when tooltip set (#5445)

e03bf61


          fix(form): remove all emotion usages (#5439)

84d0d21

* fix(form): remove all emotion usages

* fix: snapshots


          fix(Button): space in the class name (#5438)

427a21a


          fix(Button): wrong sizes (#5452)

b9a550b


          chore: release (beta) (#5451)

3fbaf2d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          feat: open prop expandable card (#5431)

ecccb99


          fix: style on individual stories (#5465)

e6ecbea


          fix: useCases category icon (#5462)

9a2eec0


          feat: vanilla extract on badge and actionBar (#5461)

6c85f1d

* feat: vanilla extract on badge and actionBar

* fix: create vanilla extract fadeIn animation


          chore: release (beta) (#5458)

54c768e

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          fix: dialog size (#5468)

af5704f


          refactor: vanilla extract banner and theme on stories (#5469)

488f767

* feat: banner vanilla extract

* fix: imports and format


          refactor: text and alert to vanilla extract (#5464)

431a325

* refactor: text and alert to vanilla extract

* fix: rebase

* fix: tests

* fix: rebase


          fix: tests (#5476)

dbc7eb2


          chore: release (beta) (#5471)

7825fef

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          feat(Avatar): use vanilla extract (#5467)

* fix: vanilla extract avatar

* fix: use css variables

* fix: tests


          refactor: vanilla extract on Separator and Loader (#5474)

269ab2f

* feat: vanilla extract separator and loader

* fix: use vanilla extract css var


          fix: add error message on code editor (#5479)

a96b83a


          fix: use css variables (#5478)

40c87b0


          fix: useless spacing classname on banner and button (#5488)

eecfc44


          feat(Popover): vanilla extract popup (#5477)

3540f4d

* feat: popup, popover and tooltip

* fix: var in new file

lisalupi and others added 28 commits

October 31, 2025 15:09


          refactor: steppedlistcard vanilla extract (#5755)

eecead1


          refactor: navigation vanilla extract (#5743)

6683a8d


          refactor: ordersummary vanilla extract (#5751)

4c52634


          refactor: line chart, selectable card option group, selectable card g…

…roup and key (#5756)


          chore(devdeps): update eslint monorepo to v9.38.0 (#5760)

0e6fd48

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore: release (beta) (#5754)

8265fe9

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          feat: style prop (#5759)

ee2f3eb

* feat: style

* fix: format

* fix: missing component

* fix: style at the end


          fix: correct TagList maxLength prop (#5758)

bc629aa


          fix: content card disabled (#5763)

396c248


          fix: migration missing subcomponents (#5762)

440d5bb

* fix: migration SelectableCardOptionGroup subcomponents

* fix: migrate other missing components


          feat: component flags (#5761)

29df8eb


          fix(OfferList): selected row and first column style (#5767)

91c824a

* fix: offer list selected

* fix: typo style


          fix: discount 100% ordersummary (#5770)

6e8d4e1


          fix: empty state title sentiment (#5772)

deba7e9


          chore: release (beta) (#5764)

65fe1f7

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          fix: make sure to clear all timers when unmount Popup (#5771)

abfbe9e


          fix(offerlist): forwards prominence to Badge (#5773)

75d6213

* fix(offerlist): forwards prominence to Badge

* fix: add prominence on badge

---------

Co-authored-by: lisa <[email protected]>


          chore: release (beta) (#5774)

db7d449

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          fix: small mistake in CSS selector (#5776)

3d50ab1

Co-authored-by: philibeaux <[email protected]>


          feat(bundle): remove cjs (#5757)

50851d4

* feat(cjs): remove cjs

* feat(cjs): remove cjs


          refactor: remove emotion from form, icons, illustrations and plus (#5768

3f0c64c

)

Co-authored-by: philibeaux <[email protected]>


          chore(devdeps): update oxlint monorepo to v1.16.0 (#5566)

88a4577

* chore(devdeps): update oxlint monorepo to v1.16.0

* fix: oxlint errors

Signed-off-by: aphilibeaux <[email protected]>

---------

Signed-off-by: aphilibeaux <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matthias <[email protected]>


          Revert "chore(devdeps): update oxlint monorepo to v1.16.0 (#5566)"

d8dd2f4

This reverts commit 88a4577.


          chore(oxlint): upgrade rule (#5778)

* chore(devdeps): update oxlint monorepo to v1.16.0

* fix: oxlint errors

Signed-off-by: aphilibeaux <[email protected]>

* chore(devdeps): update oxlint monorepo to v1.16.0 (#5566)

* chore(devdeps): update oxlint monorepo to v1.16.0

* fix: oxlint errors

Signed-off-by: aphilibeaux <[email protected]>

---------

Signed-off-by: aphilibeaux <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matthias <[email protected]>
Signed-off-by: aphilibeaux <[email protected]>

---------

Signed-off-by: aphilibeaux <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matthias <[email protected]>


          refactor: remove emotion from tests and utils (#5769)

7020d50

* refactor: remove emotion from tests and utils

* fix: typecheck

* fix: tests


          refactor: animations (#5766)

* feat: animations vanilla extract

* fix: redo animations


          feat(ui): add TreeMap chart (#5781)

* feat(ui): add TreeMap chart

* chore: use ResponsiveTreeMapHtml instead of ResponsiveTreeMap

* test: fix snapshots

* chore: lisa feedback

* chore: rename story


          fix(popup): handle auto scroll and remove useless deps effect

a8d7630

changeset-bot bot commented Nov 17, 2025

⚠️ No Changeset found

Latest commit: a8d7630

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lisalupi force-pushed the beta branch from b257afd to 13b77ac Compare

November 20, 2025 13:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet